Skip to content

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Mar 31, 2019

Successful merges:

Failed merges:

r? @ghost

Centril added 7 commits March 31, 2019 19:19
…petrochenkov

Lint for redundant imports

Add lint for redundant imports. The changes are suggested by @petrochenkov.

Closes rust-lang#10178.
…li-obk

rustc_target: factor out common fields of non-Single Variants.

@tmandry and I were discussing ways to generalize the current variants/discriminant layout to allow more fields in the "`enum`" (or another multi-variant types, such as potentially generator state, in the future), shared by all variants, than just the tag/niche discriminant.

This refactor should make it easier to extend multi-variant layouts, as nothing is duplicating anymore between "tagged enums" and "niche-filling enums".

r? @oli-obk
…swap, r=Centril

Stabilize refcell_replace_swap feature

Please be kind, this is my first time contributing. 😄

I noticed rust-lang#43570 only needs stabilizing (and I need it for a side project I'm working on), so I followed the [guide](https://rust-lang.github.io/rustc-guide/stabilization_guide.html#stabilization-pr) to move things forward.

I'm happy to amend things if needed, let me know!
Remove #[doc(hidden)] from Error::type_id

Nominating this for beta so that `Error::type_id` has documentation in time for release.

cc @rust-lang/release @rust-lang/docs
@Centril
Copy link
Contributor Author

Centril commented Mar 31, 2019

@bors r+ p=7

@bors
Copy link
Collaborator

bors commented Mar 31, 2019

📌 Commit 3445445 has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 31, 2019
@bors
Copy link
Collaborator

bors commented Mar 31, 2019

⌛ Testing commit 3445445 with merge 4fac5c9...

bors added a commit that referenced this pull request Mar 31, 2019
Rollup of 7 pull requests

Successful merges:

 - #58805 (Lint for redundant imports)
 - #59506 (Use platform dependent mcount function)
 - #59519 (rustc_target: factor out common fields of non-Single Variants.)
 - #59580 (Allow closure to unsafe fn coercion)
 - #59581 (Stabilize refcell_replace_swap feature)
 - #59583 (match match match match match)
 - #59587 (Remove #[doc(hidden)] from Error::type_id)

Failed merges:

r? @ghost
@bors
Copy link
Collaborator

bors commented Mar 31, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Centril
Pushing 4fac5c9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 31, 2019
@bors bors merged commit 3445445 into rust-lang:master Mar 31, 2019
@Centril Centril deleted the rollup branch March 31, 2019 20:28
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants